Change web3name in docs #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisChinchilla
force-pushed
the
3156-john_does-credentials-are-revoked
branch
from
9c1057a to
4bb0431
Compare
Signed-off-by: Chris Chinchilla <chris@kilt.io>
ChrisChinchilla
force-pushed
the
3156-john_does-credentials-are-revoked
branch
from
4bb0431 to
193fd5e
Compare
Signed-off-by: Chris Chinchilla <chris@kilt.io>
|
@Dudleyneedham I changed to "kiltnerd123" and this kind of works, but two things confuse me… The verification code in /getting_started/06_verify_credential.ts fails and I am not quite sure why… I removed code that tests the same on spirit net, as I didn't have enough tokens to set up the DID on spirit net, and I wasn't sure if it was necessary anyway? |
|
Yeah I also think testing for Spiritnet is not required. Can you please update the PR and resolve the conflicts? |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
@ntn-x2 Done, but I am a bit stuck on failures that have now appeared. If you have any ideas, let me know and I will dig in… |
ntn-x2
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#3156
Please include a summary of the changes provided with this pull request and which issue has been fixed.
Please also provide some context if necessary.